Skip to content

fix(builder): correctly handle edge cases #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cofin merged 2 commits into from
Dec 11, 2025
Merged

fix(builder): correctly handle edge cases #284

cofin merged 2 commits into from
Dec 11, 2025

Conversation

@cofin
Copy link
Member

@cofin cofin commented Dec 11, 2025

  • Enhance SQL builder methods to correctly handle edge cases for delete and merge operations.
  • Add tests to ensure proper functionality and error handling for invalid SQL inputs.
  • Improve count query generation to compile missing expressions.

@cofin cofin merged commit 64476a2 into main Dec 11, 2025
10 checks passed
@cofin cofin deleted the fix/issues branch December 11, 2025 19:08
@cofin cofin mentioned this pull request Dec 14, 2025
Closed
@cofin cofin linked an issue Dec 14, 2025 that may be closed by this pull request
SQL objects from get_sql() have no parsed expression, breaking select_with_total() #283
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SQL objects from get_sql() have no parsed expression, breaking select_with_total()

2 participants

@cofin