fix: handle aiosqlite 0.22.0 Connection no longer inheriting from Thread #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiosqlite 0.22.0 changed the Connection class to no longer inherit from threading.Thread. This caused AttributeError when: - Setting daemon attribute on connection - Calling is_alive() during pool shutdown Changes: - Use hasattr() check before setting daemon attribute - Use isinstance() to only track connections that are Thread instances - Move threading import to runtime for isinstance check
cofin
force-pushed
the
fix/upstream-updates
branch
from
41470a9 to
7ad27f8
Compare
cofin
changed the title
- aiosqlite: Add passive health checks (skip SELECT 1 for recently-used connections), pool warming (min_size parameter), and configurable health_check_interval. Remove dead thread tracking code from aiosqlite 0.22.0 compatibility fix. - sqlite: Change journal mode from DELETE to WAL for better concurrency (aligning with aiosqlite async pool). Add connection recycling, passive health checks, and logging. - duckdb: Wire up existing but unused _is_connection_alive() method for passive health checks on long-idle connections. Add configurable health_check_interval parameter.
Clean up dead code - all 6 adapter configs had unused logger declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes test failures in CI caused by aiosqlite 0.22.0 changing its
Connectionclass to no longer inherit fromthreading.Thread.The Problem
In aiosqlite 0.22.0, the
Connectionclass was refactored and no longer inherits fromthreading.Thread. This causedAttributeErrorwhen:daemonattribute on the connection (line 233)is_alive()on tracked threads during pool shutdown (lines 402, 411)The Solution
hasattr()to conditionally setdaemononly on older aiosqlite versionsisinstance(connection, threading.Thread)before adding to tracked threads setthreadingimport to runtime for theisinstancecheckKey Changes