feat: add NullFilter and NotNullFilter for IS NULL filtering #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add NullFilter and NotNullFilter classes for filtering database queries where columns are NULL or NOT NULL, with framework integration for FastAPI and Litestar. - NullFilter generates WHERE column IS NULL clauses - NotNullFilter generates WHERE column IS NOT NULL clauses - FastAPI/Litestar providers support via null_fields/not_null_fields config - Builder API adds where_null() and where_not_null() aliases - 13 comprehensive unit tests added
Remove where_null and where_not_null aliases since where_is_null and where_is_not_null already exist in the builder API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add NullFilter and NotNullFilter classes for filtering database queries where columns are NULL or NOT NULL, with full framework integration for FastAPI and Litestar.
The Problem
Users need to filter database queries for records where a column IS NULL or IS NOT NULL. While the builder API had
where_is_null()andwhere_is_not_null()methods, there were no corresponding filter classes for use with the framework providers, and no convenient aliases matching common SQL builder conventions.The Solution
NullFilterandNotNullFilterclasses tosqlspec/core/filters.pysqlspec/core/__init__.pynull_fieldsandnot_null_fieldsconfig options to FastAPI and Litestar providerswhere_null()andwhere_not_null()builder aliases for consistencyKey Features
WHERE column IS NULLclausesWHERE column IS NOT NULLclausesnull_fieldsandnot_null_fieldsin FilterConfigwhere_null()andwhere_not_null()for consistency with other builders