Skip to content

Conversation

@cofin
Copy link
Member

@cofin cofin commented Sep 24, 2025

Fixes the missing bind_key parameter support across all database adapter configurations

Backward Compatibility

Existing code continues to work unchanged:

# Existing code (no bind_key) - defaults to None
config = AiosqliteConfig(pool_config={"database": ":memory:"})
assert config.bind_key is None

# New CLI code (explicit bind_key)
config = AiosqliteConfig(
    pool_config={"database": ":memory:"}, 
    bind_key="my_database"
)
assert config.bind_key == "my_database"

Fixes CLI configuration loading and ensures consistent bind_key support across all database adapters as part of the configuration protocol.

@cofin cofin changed the title fix: add bind_key parameter support to all adapter configurations fix: add bind_key parameter support to all adapter configurations Sep 24, 2025
@cofin cofin merged commit d09a88d into main Sep 24, 2025
17 checks passed
@cofin cofin deleted the click-tests branch September 24, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants