Skip to content

Refactor: poll long-running operations for GCP Function deployment#1425

Merged
JosepSampe merged 4 commits intolithops-cloud:masterfrom
Bhatt21:master
Feb 27, 2025
Merged

Refactor: poll long-running operations for GCP Function deployment#1425
JosepSampe merged 4 commits intolithops-cloud:masterfrom
Bhatt21:master

Conversation

@Bhatt21
Copy link
Copy Markdown
Contributor

@Bhatt21 Bhatt21 commented Feb 26, 2025

Instead of polling the function resource (which can return 404), update the deployment logic
to poll the long-running operation returned by the create() method

More information about operation polling for gcp here

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@Bhatt21 Bhatt21 marked this pull request as ready for review February 26, 2025 20:50
@JosepSampe
Copy link
Copy Markdown
Member

JosepSampe commented Feb 27, 2025

Great! many thanks! #1421

@JosepSampe JosepSampe merged commit b157106 into lithops-cloud:master Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants