Skip to content

Handle undefined db on connect #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nearwood wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Handle undefined db on connect #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d45fd2
Check db object in case of failed connection. Add option to ignore su…
nearwood Aug 30, 2016
a980bdc
Update package.json
nearwood Aug 30, 2016
3a19678
Update README.
nearwood Aug 30, 2016
f1d92be
Revert skipSubsequentErrors option. It was a silly idea.
nearwood Aug 30, 2016
7ee8c94
Updating cache replay timing. Add metadata field.
nearwood Oct 10, 2016
406a8a6
Connect metadata field.
nearwood Oct 10, 2016
032a22b
Update mongodb and shrinkwrap.
nearwood Jul 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ function mongodbAppender(config) {
var layout = config.layout || log4js.layouts.messagePassThroughLayout;
var collectionName = config.collectionName || 'log';
var connectionOptions = config.connectionOptions || {};
var metadata = config.metadata || {};

function ERROR(err) {
Error.call(this);
Expand Down Expand Up @@ -51,7 +52,7 @@ function mongodbAppender(config) {
return dest;
}

if (!src || typeof src !== 'object' || typeof src === 'function' || src instanceof Date || src instanceof RegExp ||  src instanceof mongodb.ObjectID) {
if (!src || typeof src !== 'object' || typeof src === 'function' || src instanceof Date || src instanceof RegExp || src instanceof mongodb.ObjectID) {
return src;
}

Expand Down Expand Up @@ -96,6 +97,7 @@ function mongodbAppender(config) {
collection.insert({
timestamp: loggingEvent.startTime,
data: loggingEvent.data,
metadata: loggingEvent.metadata,
level: loggingEvent.level,
category: loggingEvent.logger.category
}, options);
Expand All @@ -104,6 +106,7 @@ function mongodbAppender(config) {
collection.insert({
timestamp: loggingEvent.startTime,
data: loggingEvent.data,
metadata: loggingEvent.metadata,
level: loggingEvent.level,
category: loggingEvent.logger.category
}, options, function (error) {
Expand All @@ -127,18 +130,20 @@ function mongodbAppender(config) {
// connect to mongodb
mongodb.MongoClient.connect(config.connectionString, connectionOptions, function (err, db) {
if (err) {
console.error('Error connecting to mongodb! URL: %s', config.connectionString);
console.error('Error connecting to mongodb');
console.error(err);
}

collection = db.collection(config.collectionName || 'log');

// process cache
cache.forEach(function (loggingEvent) {
setImmediate(function () {
insert(loggingEvent);
if (db && db.collection) {
collection = db.collection(config.collectionName || 'log', function() {
// process cache
cache.forEach(function (loggingEvent) {
setImmediate(function () {
insert(loggingEvent);
});
});
});
});
}
});

return function (loggingEvent) {
Expand All @@ -151,6 +156,7 @@ function mongodbAppender(config) {
}

loggingEvent.data = replaceKeys(loggingEvent.data);
loggingEvent.metadata = replaceKeys(metadata);

// save in db
insert(loggingEvent);
Expand Down
Loading