Skip to content

fix(litmus-agent): fix hook secret name mismatch and subscriber subchart dependency #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pierluigilenoci wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −5
Open

fix(litmus-agent): fix hook secret name mismatch and subscriber subchart dependency #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc1648c
fix(litmus-agent): replace subscriber template refs with litmus-agent…
pierluigilenoci Mar 18, 2026
064b45f
Merge branch 'master' into fix/hook-secret-name-mismatch
pierluigilenoci Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/litmus-agent/templates/infra-config-map-workflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ kind: ConfigMap
metadata:
name: {{ index .Values "workflow-controller" "appSettings" "configmapName" }}
labels:
{{- include "subscriber.labels" . | nindent 4 }}
{{- include "litmus-agent.labels" . | nindent 4 }}
annotations:
# This is what defines this resource as a hook. Without this line, the
# job is considered part of the release.
Expand Down
2 changes: 1 addition & 1 deletion charts/litmus-agent/templates/infra-config-map.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ kind: ConfigMap
metadata:
name: {{ .Values.global.infraConfigName }}
labels:
{{- include "subscriber.labels" . | nindent 4 }}
{{- include "litmus-agent.labels" . | nindent 4 }}
annotations:
# This is what defines this resource as a hook. Without this line, the
# job is considered part of the release.
Expand Down
2 changes: 1 addition & 1 deletion charts/litmus-agent/templates/infra-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ type: Opaque
metadata:
name: {{ .Values.global.infraSecretName }}
labels:
{{- include "subscriber.labels" . | nindent 4 }}
{{- include "litmus-agent.labels" . | nindent 4 }}
annotations:
# This is what defines this resource as a hook. Without this line, the
# job is considered part of the release.
Expand Down
2 changes: 1 addition & 1 deletion charts/litmus-agent/templates/secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
apiVersion: v1
kind: Secret
metadata:
name: {{ include "subscriber.fullname" . }}-hook
name: {{ include "litmus-agent.fullname" . }}-hook
labels:
{{- include "litmus-agent.labels" . | nindent 4 }}
annotations:
Expand Down
2 changes: 1 addition & 1 deletion charts/litmus-agent/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ resources:
enablePreInstallJob: true

# Existing Secret name should be:
# `{{ include "subscriber.fullname" . }}-hook`
# `{{ include "litmus-agent.fullname" . }}-hook`
# I.E. `name: litmus-agent-hook`
# -- Use an existing hook Secret instead of creating one with the chart, ref. to templates/secret.yaml
useExistingHookSecret: false
Expand Down