Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new Beamer presentation template for Nanjing Agricultural University (NJAU). The change includes defining the NJAU-specific theme configuration with its brand color and asset paths.
Key changes:
- Added NJAU template option with university-specific color scheme (RGB: 31, 80, 70) and asset paths
- Standardized code indentation throughout the file from 2-space to 4-space formatting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+146
to
+149
| \renewcommand{\maincolorRGB}{31, 80, 70} | ||
| \renewcommand{\colorlogoPath}{src/NJAU/color-logo.png} | ||
| \renewcommand{\translogoPath}{src/NJAU/trans-logo.png} | ||
| \renewcommand{\backgroundPath}{src/NJAU/background.png} |
There was a problem hiding this comment.
The NJAU option declaration is missing inline comments explaining each parameter, while similar options like CQU (lines 125-128) and ZJUT (lines 139-142) include helpful comments describing what each path represents. For consistency and maintainability, add inline comments similar to those used in CQU and ZJUT options:
- Line 146: Add comment explaining the theme's main color in RGB
- Lines 147-149: Add comments explaining the paths to color logo, transparent logo, and background image respectively
Suggested change
| \renewcommand{\maincolorRGB}{31, 80, 70} | |
| \renewcommand{\colorlogoPath}{src/NJAU/color-logo.png} | |
| \renewcommand{\translogoPath}{src/NJAU/trans-logo.png} | |
| \renewcommand{\backgroundPath}{src/NJAU/background.png} | |
| \renewcommand{\maincolorRGB}{31, 80, 70} % the theme's main color in RGB | |
| \renewcommand{\colorlogoPath}{src/NJAU/color-logo.png} % path to the logo image with background color | |
| \renewcommand{\translogoPath}{src/NJAU/trans-logo.png} % path to the logo image with transparent background | |
| \renewcommand{\backgroundPath}{src/NJAU/background.png} % path to the background image |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
为南京农业大学（NJAU, Nanjing Agricultural University)新增了模板