Implement authorization to deploy apps #3044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement UI for deployment group access control that shows all deployment groups but disables unauthorized ones. Features include: - Tooltip explaining authorization restrictions - Block cursor and disabled click handling - Mock authorization logic (production/staging disabled) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
josevalim
approved these changes
Aug 12, 2025
lib/livebook/teams.ex
Outdated
| Deploys the given app deployment to given deployment group using a deploy key. | ||
| """ | ||
| @spec authorized_user_to_deploy?(Team.t(), Teams.DeploymentGroup.t()) :: boolean() | ||
| def authorized_user_to_deploy?(%Team{} = team, %Teams.DeploymentGroup{} = deployment_group) do |
There was a problem hiding this comment.
Suggested change
| def authorized_user_to_deploy?(%Team{} = team, %Teams.DeploymentGroup{} = deployment_group) do | |
| def user_can_deploy?(%Team{} = team, %Teams.DeploymentGroup{} = deployment_group) do |
lib/livebook/teams/broadcasts.ex
Outdated
| @@ -34,6 +34,7 @@ defmodule Livebook.Teams.Broadcasts do | |||
| * `{:deployment_group_created, DeploymentGroup.t()}` | |||
| * `{:deployment_group_updated, DeploymentGroup.t()}` | |||
| * `{:deployment_group_deleted, DeploymentGroup.t()}` | |||
| * `{:deployment_authorization_updated, DeploymentGroup.t()}` | |||
There was a problem hiding this comment.
I think authorisation here can be ambiguous. Perhaps one can think it is about the authorized users? What about:
Suggested change
| * `{:deployment_authorization_updated, DeploymentGroup.t()}` | |
| * `{:deployment_users_updated, DeploymentGroup.t()}` |
| if(@active, | ||
| do: "border-blue-600 bg-blue-50", | ||
| else: "border-gray-200" | ||
| ) | ||
| ), | ||
| !@authorized && "opacity-50 bg-gray-50" |
There was a problem hiding this comment.
Keep in mind the order specified in "class" does not matter. Therefore, there is no guarantee bg-gray-50 will override the ones above. You need to replace the above into a cond instead:
cond do
!@authorized -> "tooltip top select_deployment_group"
@active -> "border-blue-600 bg-blue-50"
true -> "border-gray-200"
end
Comment on lines
316
to
317
| @selectable && @authorized && "cursor-pointer", | ||
| @selectable && !@authorized && "cursor-not-allowed", |
There was a problem hiding this comment.
Suggested change
| @selectable && @authorized && "cursor-pointer", | |
| @selectable && !@authorized && "cursor-not-allowed", | |
| @selectable && if(@authorized, do: "cursor-pointer", else: "cursor-not-allowed"), |
| ]} | ||
| phx-click={@selectable && "select_deployment_group"} | ||
| style={!@authorized && "display: block !important;"} |
There was a problem hiding this comment.
Is there a way to not use style=? 🤔
There was a problem hiding this comment.
Oops, I forgot to change to class
lib/livebook/hubs/team_client.ex
Outdated
Comment on lines
171
to
174
| def authorized_user_to_deploy?(id, user_id, deployment_group_id) do | ||
| GenServer.call( | ||
| registry_name(id), | ||
| {:check_deployment_authorization, user_id, deployment_group_id} |
There was a problem hiding this comment.
Btw, if you want another name, you could call it this:
Suggested change
| def authorized_user_to_deploy?(id, user_id, deployment_group_id) do | |
| GenServer.call( | |
| registry_name(id), | |
| {:check_deployment_authorization, user_id, deployment_group_id} | |
| def user_can_deploy?(id, user_id, deployment_group_id) do | |
| GenServer.call( | |
| registry_name(id), | |
| {:user_can_deploy?, user_id, deployment_group_id} |
It is shorter and reads a bit nicer. :)
lib/livebook/hubs/team_client.ex
Outdated
Comment on lines
750
to
761
| state.deployment_group_id == deployment_group.id and | ||
| (current_deployment_group.authorization_groups != | ||
| deployment_group.authorization_groups or | ||
| current_deployment_group.groups_auth != deployment_group.groups_auth or | ||
| current_deployment_group.teams_auth != deployment_group.teams_auth) -> | ||
| Teams.Broadcasts.server_authorization_updated(deployment_group) | ||
|
|
||
| state.deployment_group_id == nil and | ||
| (current_deployment_group.deployment_users != | ||
| deployment_group.deployment_users or | ||
| current_deployment_group.deploy_auth != deployment_group.deploy_auth) -> | ||
| Teams.Broadcasts.deployment_authorization_updated(deployment_group) |
There was a problem hiding this comment.
Technically both clauses could be the case? The current UI may imply that only one of these is true at a time, but we could not make this assumption and have two separate ifs instead?
aleDsz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.