Remove hardcoded namespace from Kubernetes YAML template #3128
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated YAML now works out of the box, all resources deploy to the user's current namespace without requiring prior setup. Users can customize the target namespace as needed.
Member
Author
|
If we want, we could leave a comment about setting a k8s namespace. But I thought this was not needed, assuming this YML is a starting point that the user will likely need to customize to their own context, which could include changes beyond just the namespace. |
josevalim
approved these changes
Jan 31, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated YAML now works out of the box, all resources deploy to the user's current namespace without requiring prior setup.
Users can customize the target namespace as needed.
Before this PR, when I tried to test locally per the instructions, they didn't work out of the box.