Do not include undefined Elixir variables in the expanded ~PY sigil #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
commented
Feb 26, 2025
lib/pythonx.ex
Outdated
| defmacro sigil_PY({:<<>>, _meta, [code]}, []) when is_binary(code) do | ||
| %{referenced: referenced, defined: defined} = Pythonx.AST.scan_globals(code) | ||
|
|
||
| versioned_vars = __CALLER__.versioned_vars |
Member
Author
There was a problem hiding this comment.
@josevalim let me know if you have any concerns with this approach :)
Contributor
There was a problem hiding this comment.
Let’s use this function instead: https://hexdocs.pm/elixir/Macro.Env.html#has_var?/2
Member
Author
There was a problem hiding this comment.
Ohh perfect, I was almost certain we had this function, it's since v1.7 so I don't know how I missed it :D Thanks!
jonatanklosko
force-pushed
the
jk-undefined-vars
branch
from
58aa50b to
4870be2
Compare
josevalim
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when
~PYreferences an undefined variable, it results in Elixir compile error, because the expanded AST references the corresponding Elixir variable. This PR changes it, such that we don't generate such AST nodes and let the Python code run and fail. This way we fail later, but provide a more informative error (actually related to the code), including line information.