Skip to content

Fix waiting on child processes blocking indefinitely #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
+14 −0
Merged

Fix waiting on child processes blocking indefinitely #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions lib/pythonx/application.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ defmodule Pythonx.Application do

@impl true
def start(_type, _args) do
enable_sigchld()

children = [
Pythonx.Janitor
]
Expand All @@ -26,4 +28,16 @@ defmodule Pythonx.Application do
else
defp maybe_uv_init(), do: :noop
end

defp enable_sigchld() do
# Some APIs in Python, such as subprocess.run, wait for a child
# OS process to finish. On Unix, this relies on `waitpid` C API,
# which does not work properly if SIGCHLD is ignored, resulting
# in infinite waiting. ERTS ignores the signal by default, so we
# explicitly restore the default handler.
case :os.type() do
{:win32, _osname} -> :ok
{:unix, _osname} -> :os.set_signal(:sigchld, :default)
end
end
end
Loading