1.3 update #32
Merged
1.3 update #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcherry
reviewed
Nov 13, 2025
src/agent.py
Outdated
| JobProcess, | ||
| MetricsCollectedEvent, | ||
| RoomInputOptions, | ||
| WorkerOptions, |
Contributor
There was a problem hiding this comment.
this can be removed - make sure you do uv run ruff check --fix . and uv run ruff format .
bcherry
reviewed
Nov 13, 2025
src/agent.py
Outdated
| await session.start( | ||
| agent=Assistant(), | ||
| room=ctx.room, | ||
| room_input_options=RoomInputOptions( |
Contributor
There was a problem hiding this comment.
this was deprecated as well - you should be using room_options=room_io.RoomOptions(audio_input=room_io.AudioInputOptions(...))
bcherry
reviewed
Nov 13, 2025
src/agent.py
Outdated
| usage_collector = metrics.UsageCollector() | ||
|
|
||
| @session.on("metrics_collected") | ||
| def _on_metrics_collected(ev: MetricsCollectedEvent): |
Contributor
There was a problem hiding this comment.
i think we can also remove the metrics collection stuff the way it is - i believe it was moved onto the various chat objects themselves
Contributor
Author
There was a problem hiding this comment.
I removed everything usage_collector related. Let me know if I should leave in log_usage.
bcherry
reviewed
Nov 17, 2025
bcherry
reviewed
Nov 17, 2025
bcherry
approved these changes
Nov 17, 2025
Co-authored-by: Ben Cherry <[email protected]>
Co-authored-by: Ben Cherry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to
agent.pyto useAgentServerand new decorators in 1.3.