Publish transcriptions additionally via text stream APIs#348
Merged
Conversation
🦋 Changeset detectedLatest commit: 1392f15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bcherry
approved these changes
Mar 28, 2025
| ): SynthesisHandle { | ||
| const synchronizer = new TextAudioSynchronizer(defaultTextSyncOptions); | ||
| synchronizer.on('textUpdated', (text) => { | ||
| // TODO: where possible we would want to use deltas instead of full text segments, esp for LLM streams over the streamText API |
Shubhrakanti
approved these changes
Apr 28, 2025
Contributor
|
Just make sure the build/tests past before merging. Thanks for bringing this to my attention. I'll include this in my agents-js 1.0 design doc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on livekit/node-sdks#447
add support for text stream based transcriptions while trying to leave things as they are otherwise.
The whole synchronizer logic (esp. wrt to deltas) should get an overhaul for 1.0 as a bunch of things changed on the python side.