Skip to content

New fix tts branch #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

New fix tts branch #812

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fc1467
Fix formatting on tts.ts
vm0809 Nov 7, 2025
4747aa6
Ensure tts.ts triggers commit
vm0809 Nov 7, 2025
4f02a85
fix: safe TTS improvements [describe your specific changes]
vm0809 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 63 additions & 35 deletions agents/src/tts/tts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,40 +157,54 @@ export abstract class SynthesizeStream
}

private async mainTask() {
let lastError: unknown;

for (let i = 0; i < this._connOptions.maxRetry + 1; i++) {
try {
return await this.run();
} catch (error) {
} catch (error: unknown) {
lastError = error;

if (error instanceof APIError) {
const retryInterval = this._connOptions._intervalForRetry(i);

if (this._connOptions.maxRetry === 0 || !error.retryable) {
this.emitError({ error, recoverable: false });
throw error;
} else if (i === this._connOptions.maxRetry) {
this.emitError({ error, recoverable: false });
throw new APIConnectionError({
message: `failed to generate TTS completion after ${this._connOptions.maxRetry + 1} attempts`,
options: { retryable: false },
});
} else {
// Don't emit error event for recoverable errors during retry loop
// to avoid ERR_UNHANDLED_ERROR or premature session termination
// Non-retryable error or retries disabled - break immediately
break;
} else if (i < this._connOptions.maxRetry) {
// Retryable error with retries remaining - log and wait
this.logger.warn(
{ tts: this.#tts.label, attempt: i + 1, error },
`failed to synthesize speech, retrying in ${retryInterval}s`,
`failed to synthesize speech, retrying in ${retryInterval}s`,
);
}

if (retryInterval > 0) {
await delay(retryInterval);
if (retryInterval > 0) {
await delay(retryInterval);
}
}
// If i === maxRetry, we break and handle below
} else {
this.emitError({ error: toError(error), recoverable: false });
throw error;
// Non-APIError - break immediately
break;
}
}
}

// Only emit error after all retries are exhausted
if (lastError) {
const error = toError(lastError);
const recoverable = error instanceof APIError && error.retryable;
this.emitError({ error, recoverable });

if (error instanceof APIError && recoverable) {
throw new APIConnectionError({
message: `failed to generate TTS completion after ${this._connOptions.maxRetry + 1} attempts`,
options: { retryable: false },
});
} else {
throw error;
}
}
}

private emitError({ error, recoverable }: { error: Error; recoverable: boolean }) {
Expand Down Expand Up @@ -385,40 +399,54 @@ export abstract class ChunkedStream implements AsyncIterableIterator<Synthesized
}

private async mainTask() {
let lastError: unknown;

for (let i = 0; i < this._connOptions.maxRetry + 1; i++) {
try {
return await this.run();
} catch (error) {
} catch (error: unknown) {
lastError = error;

if (error instanceof APIError) {
const retryInterval = this._connOptions._intervalForRetry(i);

if (this._connOptions.maxRetry === 0 || !error.retryable) {
this.emitError({ error, recoverable: false });
throw error;
} else if (i === this._connOptions.maxRetry) {
this.emitError({ error, recoverable: false });
throw new APIConnectionError({
message: `failed to generate TTS completion after ${this._connOptions.maxRetry + 1} attempts`,
options: { retryable: false },
});
} else {
// Don't emit error event for recoverable errors during retry loop
// to avoid ERR_UNHANDLED_ERROR or premature session termination
// Non-retryable error or retries disabled - break immediately
break;
} else if (i < this._connOptions.maxRetry) {
// Retryable error with retries remaining - log and wait
this.logger.warn(
{ tts: this.#tts.label, attempt: i + 1, error },
`failed to generate TTS completion, retrying in ${retryInterval}s`,
);
}

if (retryInterval > 0) {
await delay(retryInterval);
if (retryInterval > 0) {
await delay(retryInterval);
}
}
// If i === maxRetry, we break and handle below
} else {
this.emitError({ error: toError(error), recoverable: false });
throw error;
// Non-APIError - break immediately
break;
}
}
}

// Only emit error after all retries are exhausted
if (lastError) {
const error = toError(lastError);
const recoverable = error instanceof APIError && error.retryable;
this.emitError({ error, recoverable });

if (error instanceof APIError && recoverable) {
throw new APIConnectionError({
message: `failed to generate TTS completion after ${this._connOptions.maxRetry + 1} attempts`,
options: { retryable: false },
});
} else {
throw error;
}
}
}

private emitError({ error, recoverable }: { error: Error; recoverable: boolean }) {
Expand Down