Skip to content

Revert "Send all log levels to cloud observability regardless of terminal log level" #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toubatbrian merged 2 commits into from
Jan 10, 2026
Merged

Revert "Send all log levels to cloud observability regardless of terminal log level" #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad8d112
Revert "Send all log levels to cloud observability regardless of term…
toubatbrian Jan 8, 2026
539cf6b
Create nine-boxes-return.md
toubatbrian Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nine-boxes-return.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@livekit/agents': patch
---

Revert "Send all log levels to cloud observability regardless of terminal log level"
12 changes: 3 additions & 9 deletions agents/src/log.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,6 @@ class OtelDestination extends Writable {
* Enable OTEL logging by reconfiguring the logger with multistream.
* Uses a custom destination that receives full JSON logs (with msg, level, time).
*
* The base logger level is set to 'debug' so all logs are generated,
* while each stream filters to its own level:
* - Terminal: user-specified level (default: 'info')
* - OTEL/Cloud: always 'debug' to capture all logs for observability
*
* @internal
*/
export const enableOtelLogging = () => {
Expand All @@ -78,12 +73,11 @@ export const enableOtelLogging = () => {

const { pretty, level } = loggerOptions;

const terminalLevel = level || 'info';
const logLevel = level || 'info';
const streams: { stream: DestinationStream; level: string }[] = [
{ stream: pretty ? pinoPretty({ colorize: true }) : process.stdout, level: terminalLevel },
{ stream: pretty ? pinoPretty({ colorize: true }) : process.stdout, level: logLevel },
{ stream: new OtelDestination(), level: 'debug' },
];

// Base level must be 'debug' to generate all logs; each stream filters independently
logger = pino({ level: 'debug' }, multistream(streams));
logger = pino({ level: logLevel }, multistream(streams));
};