Skip to content

Conversation

@theomonnom
Copy link
Member

@theomonnom theomonnom commented Feb 19, 2025

Using libwebrtc AEC3
Everything happens in livekit-plugins/livekit-plugins-aec/copy_aec3.py (mostly)

The webrtc files take a lot of LOC, but having them inside the repo will make builds easier (instead of having to clone the libwebrtc repo)

We're copying without changes the AEC3 module, this way it's easy to keep it in sync with upstream.
This is currently using the latest commit in the libwebrtc google repo |

Everything inside src/ is the webrtc code

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2025

⚠️ No Changeset found

Latest commit: 1bdd0f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theomonnom theomonnom changed the title echo cancellation acoustic echo cancellation Feb 19, 2025
@theomonnom
Copy link
Member Author

theomonnom commented Feb 19, 2025

skipped SIMD optimizations, as it will take some time to improve the builds. Also only the console command is going to use it so not a big deal

@theomonnom theomonnom requested a review from a team February 19, 2025 22:59
@theomonnom
Copy link
Member Author

did it on the Rust side for Unity
livekit/rust-sdks#580

@theomonnom theomonnom closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants