Conversation
| and self._room._token is not None | ||
| and self._room._server_url is not None | ||
| ): | ||
| self._processor._update_credentials(token=self._room._token, url=self._room._server_url) |
There was a problem hiding this comment.
Do you think the livekit-rtc package should be responsible for directly updating the credentials?
There was a problem hiding this comment.
agree, in theory that would be nice.
I wasn't sure what the best way would be for handling the possibility of the input stream changing here further down in the rtc SDK. More than the credential update this would be about the stream info update.
Any thoughts on this?
There was a problem hiding this comment.
Had a look at this from the rtc SDK side.
One challenge I see with shifting responsibility for this to the rtc SDK is that there's no control from within the rtc SDK over when/how users construct audio streams, do you have an idea how to achieve a tighter integration between stream and the room instance?
There was a problem hiding this comment.
I see, yes, it's probably fine for now.
Maybe in the future, rtc.Room should keep track of every rtc.AudioStream, I don't see an easy way to do it today tho
xianshijing-lk
left a comment
xianshijing-lk
left a comment
There was a problem hiding this comment.
lgtm in general, one small things to get your attention
theomonnom
left a comment
theomonnom
left a comment
There was a problem hiding this comment.
lgtm! but how are users supposed to use this API?
RoomInput isn't exposed to public, only RoomIO
forgot to add the type to the AudioInputOptions 🤦 |
lukasIO
force-pushed
the
lukas/processor-support
branch
from
5fa77a4 to
f2657ec
Compare
|
ruff checks are failing on main as well due to the durable stuff, going to merge this |
…#4145) Co-authored-by: Jacob Gelman <3182119+ladvoc@users.noreply.github.com>
5 participants
depends on livekit/python-sdks#533 and livekit/python-sdks#534