Skip to content

add input_details to SpeechHandle #4701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
longcw merged 11 commits into from
Feb 9, 2026
Merged

add input_details to SpeechHandle #4701

longcw merged 11 commits into from
Feb 9, 2026
+108 −35

Conversation

@longcw
Copy link
Contributor

@longcw longcw commented Feb 3, 2026 •
edited by devin-ai-integration bot
Loading

@chenghao-mou chenghao-mou requested a review from a team February 3, 2026 09:52
@chenghao-mou chenghao-mou mentioned this pull request Feb 3, 2026
Merged
devin-ai-integration[bot]
devin-ai-integration bot reviewed Feb 3, 2026
View reviewed changes
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional flags.

Open in Devin Review

chenghao-mou
chenghao-mou approved these changes Feb 3, 2026
View reviewed changes
Copy link
Member

@chenghao-mou chenghao-mou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, two minor nitpicking comments.

davidzhao
davidzhao reviewed Feb 4, 2026
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in room_io chat handler, we should set input_mode to text right?

@longcw
Copy link
Contributor Author

longcw commented Feb 4, 2026 •
edited
Loading

in room_io chat handler, we should set input_mode to text right?

yes, it's using generate_reply and the default value is text.

davidzhao
davidzhao approved these changes Feb 4, 2026
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work!

devin-ai-integration[bot]
devin-ai-integration bot reviewed Feb 6, 2026
View reviewed changes
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 8 additional findings in Devin Review.

Open in Devin Review

devin-ai-integration[bot]
devin-ai-integration bot reviewed Feb 6, 2026
View reviewed changes
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 9 additional findings in Devin Review.

Open in Devin Review

@longcw longcw changed the title add input_mode to SpeechHandle add input_source to SpeechHandle Feb 9, 2026
devin-ai-integration[bot]
devin-ai-integration bot reviewed Feb 9, 2026
View reviewed changes
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

View 10 additional findings in Devin Review.

Open in Devin Review

theomonnom
theomonnom reviewed Feb 9, 2026
View reviewed changes
livekit-agents/livekit/agents/voice/speech_handle.py Outdated


@dataclass
class InputSource:
Copy link
Member

@theomonnom theomonnom Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we name it InputDetails?

Copy link
Contributor Author

@longcw longcw Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then it's like speech.input_details.source and speech.input_details.modality? sounds good to me

@longcw longcw changed the title add input_source to SpeechHandle add input_details to SpeechHandle Feb 9, 2026
@longcw longcw merged commit af131b8 into main Feb 9, 2026
17 of 18 checks passed
@longcw longcw deleted the longc/speech-input-mode branch February 9, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theomonnom theomonnom theomonnom left review comments

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@davidzhao davidzhao davidzhao approved these changes

@chenghao-mou chenghao-mou chenghao-mou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@longcw @davidzhao @theomonnom @chenghao-mou