Conversation
|
|
|
hi, thank you for the PR! could you sign the CLA and add the plugin to livekit-agents/pyproject.toml and pyproject.toml |
* D-ID avatar plugin (#1) * D-ID avatar plugin * ruff * formatting * updating uv.lock * Add D-ID to pyproject.toml as vendor
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
* upstream/main: feat(soniox): expose max_endpoint_delay_ms option (livekit#5214)
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
* upstream/main: fix: only start session host when it's primary session (livekit#5241) fix: prevent TTS retry after partial audio and replay input on retry (livekit#5242)
* upstream/main: fix: prevent CancelledError from propagating to unrelated Tee peers (livekit#5273)
tinalenguyen
left a comment
tinalenguyen
left a comment
There was a problem hiding this comment.
i left a few comments, also some feedback i have is that it's a bit tricky to find public avatar IDs to use with the plugin. i would recommend making it easier to find on the dashboard and also having a DEFAULT_AGENT_ID here as well so users can try it right away
| self._agent_id = agent_id | ||
| self._audio_config = audio_config or AudioConfig() | ||
| self.session_id: str | None = None | ||
|
|
There was a problem hiding this comment.
we should throw an informative error if the agent_id isn't given here
| "transport": transport, | ||
| "audio_config": audio_config, | ||
| } | ||
| response_data = await self._post(f"v2/agents/{agent_id}/sessions/join", payload) |
There was a problem hiding this comment.
are only v2 avatars supported for the plugin? it might be worth making a note in the readme
3 participants
livekit-plugins-did— a D-ID virtual avatar plugin for LiveKit Agents.examples/avatar_agents/did/AudioConfigdataclass