Skip to content

Update Phonic languages fields#5285

Open
qionghuang6 wants to merge 2 commits intolivekit:mainfrom
Phonic-Co:qiong/update-languages-fields
Open

Update Phonic languages fields#5285
qionghuang6 wants to merge 2 commits intolivekit:mainfrom
Phonic-Co:qiong/update-languages-fields

Conversation

@qionghuang6
Copy link
Copy Markdown
Contributor

Phonic recently updated it's languages fields to use a default language with additional languages. This changes our plugin to use the new fields.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

welcome_message: NotGivenOr[str | None] = NOT_GIVEN,
generate_welcome_message: NotGivenOr[bool] = NOT_GIVEN,
project: NotGivenOr[str | None] = NOT_GIVEN,
languages: NotGivenOr[list[str]] = NOT_GIVEN,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question re: backwards compatibility on patch versions

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, let me update that.

@qionghuang6 qionghuang6 force-pushed the qiong/update-languages-fields branch from 6e5d628 to 2f5778a Compare March 31, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants