fix(voice): make function call history preservation configurable in AgentTask#5288
Open
GopalGB wants to merge 1 commit intolivekit:mainfrom
Open
fix(voice): make function call history preservation configurable in AgentTask#5288GopalGB wants to merge 1 commit intolivekit:mainfrom
GopalGB wants to merge 1 commit intolivekit:mainfrom
Conversation
…gentTask AgentTask.__await_impl previously hardcoded exclude_function_call=True when merging the sub-task's chat context back into the parent agent. This unconditionally stripped all function_call and function_call_output items, causing tool call results to be lost after task completion. Adds a preserve_function_call_history parameter (default False for backward compatibility) that controls whether function call history from the sub-task is retained in the parent's chat context. Fixes livekit#5284
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preserve_function_call_historyparameter toAgentTask.__init__()(defaultFalsefor backward compatibility)True, function call and function call output items from the sub-task's chat context are retained when merging back to the parent agentexclude_function_call=Truewas hardcoded, unconditionally stripping all tool call historyRoot Cause
In
AgentTask.__await_impl, the merge call:unconditionally strips all function_call items. Users who need tool call results for context continuity (e.g., MCP tool responses, API lookups) had no way to preserve them.
Test Plan
preserve_function_call_history=False)exclude_function_callflagFixes #5284