a try to fix the windows release build #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code failed with errors like
Error: file INSTALL cannot find "D:/a/client-sdk-cpp/client-sdk-cpp/$<IF:$": File
exists.
According to ChatGPT:
It failed because install(FILES …) argument ended up containing a literal, unevaluated generator expression in the generated install script:
file INSTALL cannot find "…/$<IF:$": File exists.
That means CMake wrote something like this into build-release/cmake_install.cmake:
file(INSTALL DESTINATION ... FILES "D:/a/.../$<IF:$CONFIG:Debug, ... >")
…and then tried to install a file whose name literally begins with $<IF:... (which of course doesn’t exist).
This PR is an attempt to fix it. I don't have windows machine, so I have to land it and trigger a release for testing purpose.