Skip to content

fix: Enable E2EE for VP9 codec #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cloudwebrtc merged 3 commits into from
Jan 7, 2026
+4 −2
Merged

fix: Enable E2EE for VP9 codec #953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86094eb
Enable E2EE for SVC codec
Linquas Jan 6, 2026
6fb727e
Code cleanup
Linquas Jan 7, 2026
5f0a6ce
Do not enable E2EE for AV1 codec
Linquas Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/src/e2ee/e2ee_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class E2EEManager {
_listener!
..on<LocalTrackPublishedEvent>((event) async {
if (event.publication.encryptionType == EncryptionType.kNone ||
isSVCCodec(event.publication.track?.codec ?? '')) {
isAV1Codec(event.publication.track?.codec ?? '')) {
// no need to setup frame cryptor
return;
}
Expand Down Expand Up @@ -81,7 +81,7 @@ class E2EEManager {
})
..on<TrackSubscribedEvent>((event) async {
final codec = event.publication.mimeType.split('/')[1];
if (event.publication.encryptionType == EncryptionType.kNone || isSVCCodec(codec)) {
if (event.publication.encryptionType == EncryptionType.kNone || isAV1Codec(codec)) {
// no need to setup frame cryptor
return;
}
Expand Down
2 changes: 2 additions & 0 deletions lib/src/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,8 @@ const refreshSubscribedCodecAfterNewCodec = 5000;

bool isSVCCodec(String codec) => ['vp9', 'av1'].contains(codec.toLowerCase());

bool isAV1Codec(String codec) => codec.toLowerCase() == 'av1';

class ScalabilityMode {
late num spatial;

Expand Down