Skip to content

Allow audio processing for react native without AudioContext #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidliu merged 3 commits into from
Feb 4, 2025
Merged

Allow audio processing for react native without AudioContext #1395

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8df8b72
Allow audio processing for react native without AudioContext
davidliu Feb 3, 2025
ce414f5
changeset
davidliu Feb 3, 2025
e42b910
Force ignore audio context nullability in processorOptions
davidliu Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/many-paws-join.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'livekit-client': patch
---

Allow audio processing for react native without AudioContext
6 changes: 4 additions & 2 deletions src/room/track/LocalAudioTrack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { TrackEvent } from '../events';
import { computeBitrate, monitorFrequency } from '../stats';
import type { AudioSenderStats } from '../stats';
import type { LoggerOptions } from '../types';
import { isWeb, unwrapConstraint } from '../utils';
import { isReactNative, isWeb, unwrapConstraint } from '../utils';
import LocalTrack from './LocalTrack';
import { Track } from './Track';
import type { AudioCaptureOptions } from './options';
Expand Down Expand Up @@ -171,7 +171,7 @@ export default class LocalAudioTrack extends LocalTrack<Track.Kind.Audio> {
async setProcessor(processor: TrackProcessor<Track.Kind.Audio, AudioProcessorOptions>) {
const unlock = await this.processorLock.lock();
try {
if (!this.audioContext) {
if (!isReactNative() && !this.audioContext) {
throw Error(
'Audio context needs to be set on LocalAudioTrack in order to enable processors',
);
Expand All @@ -187,6 +187,8 @@ export default class LocalAudioTrack extends LocalTrack<Track.Kind.Audio> {
};
this.log.debug(`setting up audio processor ${processor.name}`, this.logContext);

// RN won't have AudioContext.
// @ts-expect-error
await processor.init(processorOptions);
this.processor = processor;
if (this.processor.processedTrack) {
Expand Down
Loading