Skip to content

Move RPC registration to room level#1396

Merged
lukasIO merged 9 commits intomainfrom
lukas/rpc-room
Feb 5, 2025
Merged

Move RPC registration to room level#1396
lukasIO merged 9 commits intomainfrom
lukas/rpc-room

Conversation

@lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Feb 4, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: c1b984a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 89.8 KB (0%)
dist/livekit-client.umd.js 95.87 KB (0%)

@lukasIO lukasIO requested a review from bcherry February 4, 2025 14:18
Copy link
Contributor

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. passing the map into LP for the deprecated methods seems surprisingly clean!

@lukasIO lukasIO merged commit 4be40ba into main Feb 5, 2025
3 checks passed
@lukasIO lukasIO deleted the lukas/rpc-room branch February 5, 2025 09:03
@github-actions github-actions bot mentioned this pull request Feb 5, 2025
svajunas-budrys pushed a commit to svajunas-budrys/client-sdk-js that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants