Skip to content

Reject publishing with insufficient permissions present#1418

Merged
lukasIO merged 3 commits intomainfrom
lukas/reject-local-pub
Feb 25, 2025
Merged

Reject publishing with insufficient permissions present#1418
lukasIO merged 3 commits intomainfrom
lukas/reject-local-pub

Conversation

@lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Feb 25, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 4614d02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO lukasIO requested review from a team and davidzhao February 25, 2025 08:41
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 90.34 KB (+0.25% 🔺)
dist/livekit-client.umd.js 97.99 KB (+0.22% 🔺)

boks1971
boks1971 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@boks1971 boks1971 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but one question
do apps now call publish again so that SDK can do AddTrack when it has permissions or is there a need to cache the publish intent and do an AddTrack when permissions are granted?

davidzhao
davidzhao approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@lukasIO
Copy link
Contributor Author

lukasIO commented Feb 25, 2025 •
edited
Loading

do apps now call publish again so that SDK can do AddTrack when it has permissions or is there a need to cache the publish intent and do an AddTrack when permissions are granted?

I don't think we should cache publish intent.
The current behaviour is similar, where publishing will eventually fail, just without providing adequate user feedback.

@lukasIO lukasIO merged commit 75a245a into main Feb 25, 2025
3 checks passed
@lukasIO lukasIO deleted the lukas/reject-local-pub branch February 25, 2025 12:02
@github-actions github-actions bot mentioned this pull request Feb 25, 2025
Merged
svajunas-budrys pushed a commit to svajunas-budrys/client-sdk-js that referenced this pull request Jun 17, 2025
@lukasIO @svajunas-budrys
Reject publishing with insufficient permissions present (livekit#1418)
e631b3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulwe paulwe paulwe approved these changes

@davidzhao davidzhao davidzhao approved these changes

@boks1971 boks1971 boks1971 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lukasIO @paulwe @davidzhao @boks1971