Skip to content

Fix publish permission check #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasIO merged 1 commit into from
Feb 26, 2025
Merged

Fix publish permission check #1420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/room/participant/LocalParticipant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,21 +875,25 @@ export default class LocalParticipant extends Participant {

private hasPermissionsToPublish(track: LocalTrack): boolean {
if (!this.permissions) {
this.log.warn('no permissions present for publishing track', {
...this.logContext,
...getLogContextFromTrack(track),
});
return false;
}
const { canPublish, canPublishSources } = this.permissions;
if (
!canPublish ||
canPublish ||
(canPublishSources &&
!canPublishSources.map((source) => getTrackSourceFromProto(source)).includes(track.source))
canPublishSources.map((source) => getTrackSourceFromProto(source)).includes(track.source))
) {
this.log.error('insufficient permissions to publish', {
...this.logContext,
...getLogContextFromTrack(track),
});
return false;
return true;
}
return true;
this.log.warn('insufficient permissions to publish', {
...this.logContext,
...getLogContextFromTrack(track),
});
return false;
}

private async publish(track: LocalTrack, opts: TrackPublishOptions, isStereo: boolean) {
Expand Down
Loading