chore(react): deprecate legacy useTrackTranscriptions#1200
Conversation
🦋 Changeset detectedLatest commit: 687419e The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
…t/components-js into lukas/deprecate-old-transcription
| * @internal | ||
| * @deprecated Use useTrackSyncTime instead | ||
| */ | ||
| export function useTrackSyncTime(ref: TrackReferenceOrPlaceholder | undefined) { |
There was a problem hiding this comment.
Is this saying that a function is deprecated, but that a user should use the same deprecated function instead? Maybe there's a different useTrackSyncTime somewhere this is referring to, but as is it's kinda confusing.
Something that could maybe help that confusion - there's a @link tsdoc directive (more info) that could maybe be used to link to the correct implementation. If this seems like a good plan, I can make a ticket to do a pass and apply this everywhere?
There was a problem hiding this comment.
uff, thanks for catching, that doesn't make any sense. It was used internally only anyways, the deprecated marker serves primarily as a reminder for us to remove it entirely for the next iteration
There was a problem hiding this comment.
yeah, using the link directive would be great!
|
TypeScript error in useTrackSyncTime: type mismatch between trackSyncTimeObserver and useObservableState Bug DescriptionTypeScript compilation error in Error MessageLocation
Environment
Expected BehaviorCode should compile without TypeScript errors. Actual BehaviorTypeScript reports type mismatch between Possible FixThe observable returned by
WorkaroundUsing |
No description provided.