Fix livekit-client internal export usage#1289
Merged
Conversation
The ts-ignore comments above (most) don't get copied into the resulting built version of the code so these issues still get raised by downstream users who rely on using the typing files in `dist/`. Relevant upstream change this relies on: livekit/client-sdk-js#1815
🦋 Changeset detectedLatest commit: 808bf08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
lukasIO
approved these changes
Feb 19, 2026
Contributor
lukasIO
left a comment
lukasIO
left a comment
There was a problem hiding this comment.
nice!
the pnpm-lock diff is unexpectedly large, not sure why, but guess that's ok. Just wondering why we didn't see that change before
Contributor
|
aha! yeah, something's off there, the lock file is also why the CI is failing |
Contributor
Author
|
I noticed that too but figured it was due to some dependency updates in |
Turns out I have made some quite substantial modifications to My local copies of the examples, oops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
@livekit/components-corecontained a bunch of imports like this:However, some downstream users (probably with the node module resolution configuration mentioned) were still getting build errors when attempting to use types in
@livekit/components-core/dist/....I think this is because the
@ts-ignorecomments above (most) don't get copied into the resulting built version of the code so these issues still get raised by downstream users who rely on using the typing files indist/. So, instead, use proper exports from the top levellivekit-clientpackage.After making this change, I built the
@livekit/components-corepackage and did a grep forlivekit-client/distin the built output and found no remaining occurrences.Relevant upstream change this relies on: livekit/client-sdk-js#1815