fix(react): handle renamed key in room options serializer#1312
Merged
1egoman merged 2 commits intolivekit:mainfrom Mar 20, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 511d97e The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@afgarcia86 is attempting to deploy a commit to the LiveKit Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1egoman
approved these changes
Mar 20, 2026
Contributor
1egoman
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client-sdk-jsmarkede2eeas a deprecated key in favor ofencryption, butroomOptionsStringifyReplaceronly special-casede2ee. This caused the encryption object (with new worker/keyProvider references each render) to be compared by value, triggering a reconnect loop when using the new key.