Skip to content

Conversation

@rektdeckard
Copy link
Member

@rektdeckard rektdeckard commented Dec 9, 2024

  • lk app env command is no longer hidden
  • lk app env now prints to stdout instead of clobbering .env.local unexpectedly, but can be called with the --write flag to keep previous behavior
  • lk app env [DIR] is now supported, allowing you tun run outside CWD
  • We no longer print an error if a template cloned using lk app create does not contain a taskfile.yaml, it is now considered optional

NOTE: we no longer recursively search the whole project for .env.example files -- only in the root directory. This means that we don't support "meta templates" that stitch together other templates to make a full application stack, but we were not using it anyway, and prefer to direct users to bootstrap each component separately.

@rektdeckard rektdeckard requested a review from davidzhao December 9, 2024 19:36
@rektdeckard rektdeckard force-pushed the tobias/dex-994-lk-app-env-should-emit-to-stdout-instead-of-overwriting-by branch from f547eb2 to 748fb57 Compare December 9, 2024 19:41
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

one question / potential feature creep: does this work when I'm outside of a bootstrapped project too? It seems that the common env vars could be useful even outside of the context of bootstrap

@rektdeckard
Copy link
Member Author

rektdeckard commented Dec 9, 2024

@davidzhao it works with any directory with a .env.example file 👍.

Might also be nice to let this command accept an optional path argument, so you can point it to a directory besides the CWD?

@rektdeckard rektdeckard merged commit 77f1841 into main Dec 9, 2024
3 checks passed
@rektdeckard rektdeckard deleted the tobias/dex-994-lk-app-env-should-emit-to-stdout-instead-of-overwriting-by branch December 9, 2024 22:39
@rektdeckard
Copy link
Member Author

Or were you saying that in the absence of a .env.example file, lk app env should just always print API Key, Secret, and URL of the default or selected project, in shell variable format, wherever you are?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants