add support for project lookup via subdomain #537
Conversation
real-danm
commented
Mar 24, 2025
real-danm
commented
- more explicit path'ing and workdir for agent hosting commands
- add the subdomain project lookup to support agent hosting toml
- for agent hosting list command, add a project-id param to allow listing agents on projects other than the default project
…ain project lookup to support agent hosting toml
|
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to refer to the manpage for more information. |
cmd/lk/agent.go
Outdated
| &cli.StringFlag{ | ||
| Name: "project", | ||
| Usage: "Project to list agents for", | ||
| Required: false, | ||
| }, |
There was a problem hiding this comment.
This is already a "persistent" flag, so it is valid on every command and its subcommands, and not necessary to redefine here. See: https://github.com/livekit/livekit-cli/blob/main/cmd/lk/utils.go#L65-L68
There was a problem hiding this comment.
But if you're adding it here to override the Usage string to indicate that the project name can be ANY project, not just those you've added to the CLI, this is fine! Or we can just come up with a more general helpstring that suits both.
There was a problem hiding this comment.
Ah, right.. good call, will remove the duplicate.
