Skip to content

Fixing replay after protocol dep bump #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexlivekit merged 3 commits into from
Sep 22, 2025
Merged

Fixing replay after protocol dep bump #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f5b890
Pullong latest protocol
alexlivekit Sep 22, 2025
fa31c59
Replay fix:
alexlivekit Sep 22, 2025
2559f8d
Adding configurable room to list per changes in livekit/protocol
alexlivekit Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions cmd/lk/replay.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,14 @@ var (
Name: "list",
Before: createReplayClient,
Action: listReplays,
Flags: []cli.Flag{jsonFlag},
Flags: []cli.Flag{
jsonFlag,
&cli.StringFlag{
Name: "room",
Usage: "Playback room name",
Required: false,
},
},
},
{
Name: "load",
Expand Down Expand Up @@ -135,7 +142,9 @@ func listReplays(ctx context.Context, cmd *cli.Command) error {
return err
}

req := &replay.ListReplaysRequest{}
req := &replay.ListReplaysRequest{
RoomName: cmd.String("room"),
}
res, err := replayClient.ListReplays(ctx, req)
if err != nil {
return err
Expand All @@ -160,12 +169,12 @@ func loadReplay(ctx context.Context, cmd *cli.Command) error {
return err
}

req := &replay.LoadReplayRequest{
ReplayId: cmd.String("id"),
RoomName: cmd.String("room"),
StartingPts: int64(cmd.Int("pts")),
req := &replay.PlaybackRequest{
ReplayId: cmd.String("id"),
RoomName: cmd.String("room"),
StartTime: int64(cmd.Int("pts")),
}
res, err := replayClient.LoadReplay(ctx, req)
res, err := replayClient.Playback(ctx, req)
if err != nil {
return err
}
Expand All @@ -180,11 +189,11 @@ func seek(ctx context.Context, cmd *cli.Command) error {
return err
}

req := &replay.RoomSeekRequest{
req := &replay.SeekRequest{
PlaybackId: cmd.String("id"),
Pts: int64(cmd.Int("pts")),
StartTime: int64(cmd.Int("pts")),
}
_, err = replayClient.SeekForRoom(ctx, req)
_, err = replayClient.Seek(ctx, req)
return err
}

Expand All @@ -194,10 +203,10 @@ func closeReplay(ctx context.Context, cmd *cli.Command) error {
return err
}

req := &replay.CloseReplayRequest{
req := &replay.ClosePlaybackRequest{
PlaybackId: cmd.String("id"),
}
_, err = replayClient.CloseReplay(ctx, req)
_, err = replayClient.Close(ctx, req)
return err
}

Expand Down
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ require (
github.com/go-logr/logr v1.4.3
github.com/go-task/task/v3 v3.44.1
github.com/joho/godotenv v1.5.1
github.com/livekit/protocol v1.41.0
github.com/livekit/protocol v1.41.1-0.20250922191558-7ca55b4334c9
github.com/livekit/server-sdk-go/v2 v2.11.3
github.com/moby/buildkit v0.23.2
github.com/moby/patternmatcher v0.6.0
Expand Down Expand Up @@ -120,7 +120,7 @@ require (
github.com/lithammer/shortuuid/v4 v4.2.0 // indirect
github.com/livekit/mageutil v0.0.0-20250511045019-0f1ff63f7731 // indirect
github.com/livekit/mediatransportutil v0.0.0-20250825135402-7bc31f107ade // indirect
github.com/livekit/psrpc v0.6.1-0.20250726180611-3915e005e741 // indirect
github.com/livekit/psrpc v0.7.0 // indirect
github.com/lucasb-eyer/go-colorful v1.2.0 // indirect
github.com/magefile/mage v1.15.0 // indirect
github.com/mattn/go-colorable v0.1.14 // indirect
Expand Down
8 changes: 4 additions & 4 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,10 +274,10 @@ github.com/livekit/mageutil v0.0.0-20250511045019-0f1ff63f7731 h1:9x+U2HGLrSw5AT
github.com/livekit/mageutil v0.0.0-20250511045019-0f1ff63f7731/go.mod h1:Rs3MhFwutWhGwmY1VQsygw28z5bWcnEYmS1OG9OxjOQ=
github.com/livekit/mediatransportutil v0.0.0-20250825135402-7bc31f107ade h1:lpxPcglwzUWNB4J0S2qZuyMehzmR7vW9whzSwV4IGoI=
github.com/livekit/mediatransportutil v0.0.0-20250825135402-7bc31f107ade/go.mod h1:mSNtYzSf6iY9xM3UX42VEI+STHvMgHmrYzEHPcdhB8A=
github.com/livekit/protocol v1.41.0 h1:aCMkM/MEmiZt7LRoZAfo1muZYjlioaw+NbVnkUDpgn8=
github.com/livekit/protocol v1.41.0/go.mod h1:Scx8arfj5y65w6EYA3ZIKJafoN2xBuV8pauvyrvI4eg=
github.com/livekit/psrpc v0.6.1-0.20250726180611-3915e005e741 h1:KKL1u94l6dF9u4cBwnnfozk27GH1txWy2SlvkfgmzoY=
github.com/livekit/psrpc v0.6.1-0.20250726180611-3915e005e741/go.mod h1:AuDC5uOoEjQJEc69v4Li3t77Ocz0e0NdjQEuFfO+vfk=
github.com/livekit/protocol v1.41.1-0.20250922191558-7ca55b4334c9 h1:xD69GyLf1oxMuEThna7NxkUSD8Ntunx/pBuqa7J6tPM=
github.com/livekit/protocol v1.41.1-0.20250922191558-7ca55b4334c9/go.mod h1:vhMS30QoEyH2p34vi6X1eWkC4EMV72ZGZwQb74ajY7A=
github.com/livekit/psrpc v0.7.0 h1:rtfqfjYN06WJYloE/S0nmkJ/Y04x4pxLQLe8kQ4FVHU=
github.com/livekit/psrpc v0.7.0/go.mod h1:AuDC5uOoEjQJEc69v4Li3t77Ocz0e0NdjQEuFfO+vfk=
github.com/livekit/server-sdk-go/v2 v2.11.3 h1:k+YDxo8wPCixRrS9fJHcbtlurlXhVLfyPva5Ne4tVH0=
github.com/livekit/server-sdk-go/v2 v2.11.3/go.mod h1:ZRI95+32aJIC4BI0hV0h/XfHcX9Vrk7zcT2mKG1Q758=
github.com/lucasb-eyer/go-colorful v1.2.0 h1:1nnpGOrhyZZuNyfu1QjKiUICQ74+3FNCN69Aj6K7nkY=
Expand Down
Loading