Skip to content

Updated phone number api #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nishadmusthafa merged 2 commits into from
Oct 24, 2025
Merged

Updated phone number api #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1f1bee
Updated phone number api
nishadmusthafa Oct 17, 2025
3e8d40b
Changing helper text for statuses
nishadmusthafa Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 24 additions & 18 deletions cmd/lk/phone_number.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ var (
Usage: "Maximum number of results (default: 50)",
Value: 50,
},
&cli.StringFlag{
&cli.StringSliceFlag{
Name: "status",
Usage: "Filter by status (active, pending, released)",
Usage: "Filter by status(es) (active, pending, released). Mutliple values can be specified.",
},
&cli.StringFlag{
Name: "sip-dispatch-rule-id",
Expand Down Expand Up @@ -172,10 +172,11 @@ func searchPhoneNumbers(ctx context.Context, cmd *cli.Command) error {
req.CountryCode = val
}
if val := cmd.String("area-code"); val != "" {
req.AreaCode = val
req.AreaCode = &val
}
if val := cmd.Int("limit"); val != 0 {
req.Limit = int32(val)
limit := int32(val)
req.Limit = &limit
}

resp, err := client.SearchPhoneNumbers(ctx, req)
Expand Down Expand Up @@ -229,7 +230,7 @@ func purchasePhoneNumbers(ctx context.Context, cmd *cli.Command) error {
PhoneNumbers: phoneNumbers,
}
if val := cmd.String("sip-dispatch-rule-id"); val != "" {
req.SipDispatchRuleId = val
req.SipDispatchRuleId = &val
}

resp, err := client.PurchasePhoneNumber(ctx, req)
Expand Down Expand Up @@ -258,17 +259,22 @@ func listPhoneNumbers(ctx context.Context, cmd *cli.Command) error {

req := &livekit.ListPhoneNumbersRequest{}
if val := cmd.Int("limit"); val != 0 {
req.Limit = int32(val)
}
if val := cmd.String("status"); val != "" {
status, ok := livekit.PhoneNumberStatus_value["PHONE_NUMBER_STATUS_"+strings.ToUpper(val)]
if !ok {
return fmt.Errorf("invalid status: %s", val)
limit := int32(val)
req.Limit = &limit
}
if statuses := cmd.StringSlice("status"); len(statuses) > 0 {
var phoneNumberStatuses []livekit.PhoneNumberStatus
for _, status := range statuses {
statusValue, ok := livekit.PhoneNumberStatus_value["PHONE_NUMBER_STATUS_"+strings.ToUpper(status)]
if !ok {
return fmt.Errorf("invalid status: %s", status)
}
phoneNumberStatuses = append(phoneNumberStatuses, livekit.PhoneNumberStatus(statusValue))
}
req.Status = livekit.PhoneNumberStatus(status)
req.Statuses = phoneNumberStatuses
}
if val := cmd.String("sip-dispatch-rule-id"); val != "" {
req.SipDispatchRuleId = val
req.SipDispatchRuleId = &val
}

resp, err := client.ListPhoneNumbers(ctx, req)
Expand Down Expand Up @@ -320,9 +326,9 @@ func getPhoneNumber(ctx context.Context, cmd *cli.Command) error {

req := &livekit.GetPhoneNumberRequest{}
if id != "" {
req.Id = id
req.Id = &id
} else {
req.PhoneNumber = phoneNumber
req.PhoneNumber = &phoneNumber
}

resp, err := client.GetPhoneNumber(ctx, req)
Expand Down Expand Up @@ -372,12 +378,12 @@ func updatePhoneNumber(ctx context.Context, cmd *cli.Command) error {

req := &livekit.UpdatePhoneNumberRequest{}
if id != "" {
req.Id = id
req.Id = &id
} else {
req.PhoneNumber = phoneNumber
req.PhoneNumber = &phoneNumber
}
if val := cmd.String("sip-dispatch-rule-id"); val != "" {
req.SipDispatchRuleId = val
req.SipDispatchRuleId = &val
}

resp, err := client.UpdatePhoneNumber(ctx, req)
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ require (
github.com/go-logr/logr v1.4.3
github.com/go-task/task/v3 v3.44.1
github.com/joho/godotenv v1.5.1
github.com/livekit/protocol v1.42.2-0.20251016024155-8cf58ff15ac6
github.com/livekit/protocol v1.42.3-0.20251024111301-1e3becbff5d1
github.com/livekit/server-sdk-go/v2 v2.12.1
github.com/moby/patternmatcher v0.6.0
github.com/pelletier/go-toml v1.9.5
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,8 @@ github.com/livekit/mageutil v0.0.0-20250511045019-0f1ff63f7731 h1:9x+U2HGLrSw5AT
github.com/livekit/mageutil v0.0.0-20250511045019-0f1ff63f7731/go.mod h1:Rs3MhFwutWhGwmY1VQsygw28z5bWcnEYmS1OG9OxjOQ=
github.com/livekit/mediatransportutil v0.0.0-20250825135402-7bc31f107ade h1:lpxPcglwzUWNB4J0S2qZuyMehzmR7vW9whzSwV4IGoI=
github.com/livekit/mediatransportutil v0.0.0-20250825135402-7bc31f107ade/go.mod h1:mSNtYzSf6iY9xM3UX42VEI+STHvMgHmrYzEHPcdhB8A=
github.com/livekit/protocol v1.42.2-0.20251016024155-8cf58ff15ac6 h1:Tby1v0yn0XCXl9nBVnZI9M1cQW/0o4E/ejzRgcaMETI=
github.com/livekit/protocol v1.42.2-0.20251016024155-8cf58ff15ac6/go.mod h1:vhMS30QoEyH2p34vi6X1eWkC4EMV72ZGZwQb74ajY7A=
github.com/livekit/protocol v1.42.3-0.20251024111301-1e3becbff5d1 h1:MBlwsnh1Zf8cb4MiflfyIglEZKfodkcE6JUvp+8M9i0=
github.com/livekit/protocol v1.42.3-0.20251024111301-1e3becbff5d1/go.mod h1:ODNQZnKVH2U93PMn/NwcpPV6zOrilBpYbyncjn/rHZI=
github.com/livekit/psrpc v0.7.0 h1:rtfqfjYN06WJYloE/S0nmkJ/Y04x4pxLQLe8kQ4FVHU=
github.com/livekit/psrpc v0.7.0/go.mod h1:AuDC5uOoEjQJEc69v4Li3t77Ocz0e0NdjQEuFfO+vfk=
github.com/livekit/server-sdk-go/v2 v2.12.1 h1:6F4OWwWPcUjyhaWPNL5BE1XEJt9KzX4/10P5ADeL7xY=
Expand Down