support agent region #713
support agent region #713
Conversation
|
A select would be nice if the property is not provided! With so much remote work I don't think it's safe to assume closest region to host machine. Can regions be listed by the client or does that API need adding? |
i think we can use the 'settings' api offered by cloud agents to return the currently enabled regions |
| } else { | ||
| // we shouldn't ever get here, but if we do, just default to us-east | ||
| logger.Debugw("no available regions found, defaulting to us-east. please contact LiveKit support if this is unexpected.") | ||
| region = "us-east" |
There was a problem hiding this comment.
Shouldn't default region be empty?
There was a problem hiding this comment.
hmm i wasn't sure here. if it's empty then whichever region picks it up based on dns of the api call would deploy it. not sure if that is better or to use us-east
rektdeckard
left a comment
rektdeckard
left a comment
There was a problem hiding this comment.
Nice! Can you add the flag to initAgent too? Just the flag definition needs to be there, we forward everything to createAgent.
added this to initAgent flags, hopefully this is what you need? 47fba4d |
|
@real-danm yep, thank you! |
added a select themed with the standard form to select from available regions.