Skip to content

Display owner for cloud-agent version #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yoonsio wants to merge 1 commit into from
Closed

Display owner for cloud-agent version #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmd/lk/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,17 +959,22 @@ func listAgentVersions(ctx context.Context, cmd *cli.Command) error {
}

table := util.CreateTable().
Headers("Version", "Current", "Status", "Created At", "Deployed At")
Headers("Version", "Current", "Status", "Owner", "Created At", "Deployed At")

// Sort versions by created date descending
slices.SortFunc(versions.Versions, func(a, b *lkproto.AgentVersion) int {
return b.CreatedAt.AsTime().Compare(a.CreatedAt.AsTime())
})
for _, version := range versions.Versions {
owner := version.Owner
Copy link
Member

@rektdeckard rektdeckard Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an owner ID, not a name, correct? Unsure if that's really useful info in the context of the CLI. Maybe we should just leave it to the dashboard to surface the full name of the version owner?

Copy link
Contributor Author

@yoonsio yoonsio Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah does livekit-cli has access to user table?

Copy link
Member

@rektdeckard rektdeckard Oct 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, and we don't have session-token auth so we can't call cloud-api methods directory very easily.

if owner == "" {
owner = "-"
}
table.Row(
version.Version,
fmt.Sprintf("%t", version.Current),
version.Status,
owner,
version.CreatedAt.AsTime().Format(time.RFC3339),
version.DeployedAt.AsTime().Format(time.RFC3339),
)
Expand Down
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ require (
github.com/go-logr/logr v1.4.3
github.com/go-task/task/v3 v3.44.1
github.com/joho/godotenv v1.5.1
github.com/livekit/protocol v1.42.3-0.20251024111301-1e3becbff5d1
github.com/livekit/protocol v1.42.3-0.20251027202258-45a0f58f19cb
github.com/livekit/server-sdk-go/v2 v2.12.1
github.com/moby/patternmatcher v0.6.0
github.com/pelletier/go-toml v1.9.5
Expand Down Expand Up @@ -113,7 +113,7 @@ require (
github.com/lithammer/shortuuid/v4 v4.2.0 // indirect
github.com/livekit/mageutil v0.0.0-20250511045019-0f1ff63f7731 // indirect
github.com/livekit/mediatransportutil v0.0.0-20250825135402-7bc31f107ade // indirect
github.com/livekit/psrpc v0.7.0 // indirect
github.com/livekit/psrpc v0.7.1-0.20251021235041-bdebea7dacf4 // indirect
github.com/lucasb-eyer/go-colorful v1.2.0 // indirect
github.com/magefile/mage v1.15.0 // indirect
github.com/mattn/go-colorable v0.1.14 // indirect
Expand Down
4 changes: 4 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,12 @@ github.com/livekit/mediatransportutil v0.0.0-20250825135402-7bc31f107ade h1:lpxP
github.com/livekit/mediatransportutil v0.0.0-20250825135402-7bc31f107ade/go.mod h1:mSNtYzSf6iY9xM3UX42VEI+STHvMgHmrYzEHPcdhB8A=
github.com/livekit/protocol v1.42.3-0.20251024111301-1e3becbff5d1 h1:MBlwsnh1Zf8cb4MiflfyIglEZKfodkcE6JUvp+8M9i0=
github.com/livekit/protocol v1.42.3-0.20251024111301-1e3becbff5d1/go.mod h1:ODNQZnKVH2U93PMn/NwcpPV6zOrilBpYbyncjn/rHZI=
github.com/livekit/protocol v1.42.3-0.20251027202258-45a0f58f19cb h1:nhAa6rnJF3CC/0TPSnRdTEsltOvX6dm/IyQe+z/pmOk=
github.com/livekit/protocol v1.42.3-0.20251027202258-45a0f58f19cb/go.mod h1:TpqU2qCI1ES4Lk7PAWSgYO4RaexfVXb54ZO2hXv0Bmc=
github.com/livekit/psrpc v0.7.0 h1:rtfqfjYN06WJYloE/S0nmkJ/Y04x4pxLQLe8kQ4FVHU=
github.com/livekit/psrpc v0.7.0/go.mod h1:AuDC5uOoEjQJEc69v4Li3t77Ocz0e0NdjQEuFfO+vfk=
github.com/livekit/psrpc v0.7.1-0.20251021235041-bdebea7dacf4 h1:YA5HMfNW9IPPdTSkwsyCtK9ZcNW8QpPNlkuD7UUToZE=
github.com/livekit/psrpc v0.7.1-0.20251021235041-bdebea7dacf4/go.mod h1:AuDC5uOoEjQJEc69v4Li3t77Ocz0e0NdjQEuFfO+vfk=
github.com/livekit/server-sdk-go/v2 v2.12.1 h1:6F4OWwWPcUjyhaWPNL5BE1XEJt9KzX4/10P5ADeL7xY=
github.com/livekit/server-sdk-go/v2 v2.12.1/go.mod h1:6EZr5pBYOJ4cT1i5YnZ/L+GOeOqx6e6fKtVgU8itXuc=
github.com/lucasb-eyer/go-colorful v1.2.0 h1:1nnpGOrhyZZuNyfu1QjKiUICQ74+3FNCN69Aj6K7nkY=
Expand Down
Loading