Changing up how dispatch rules are assigned to numbers #726
Conversation
rektdeckard
left a comment
rektdeckard
left a comment
There was a problem hiding this comment.
LGTM.
I really want us to rethink if using the same PhoneNumber model for inventory and owned numbers is a good idea. This info should be able to be preloaded on numbers response, not stitched together in each client of the data. We already do something similar in dashboard and it is painful and error prone.
| sipClient := lksdk.NewSIPClient(project.URL, project.APIKey, project.APISecret, withDefaultClientOpts(project)...) | ||
|
|
||
| // List all dispatch rules | ||
| resp, err := sipClient.ListSIPDispatchRule(ctx, &livekit.ListSIPDispatchRuleRequest{}) |
There was a problem hiding this comment.
Just noting, we still haven't resolved the issue with max twirp message size, either here or in SDK. Probably very few customers hitting that but we need to come back to the idea of auto-paginating results when we do things like this.
There was a problem hiding this comment.
this is similar to what we've done here -> https://github.com/livekit/livekit-cli/pull/694/files ? I can take that up after landing this.
There was a problem hiding this comment.
Yeah, that was the idea for a short-term fix. What we probably want to for real tho is something like this if the results are requested in JSON format (complete results are expected) but have real pagination in the CLI for when you expect a table format (just call with nextPageToken on arrow key or something).
No description provided.