Skip to content

Temporarily disable pino-pretty transport #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasIO merged 2 commits into from
Jan 9, 2026
Merged

Temporarily disable pino-pretty transport #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6411d55
Temporarily disable pino-pretty transport
lukasIO Jan 8, 2026
44668e9
Create wild-tools-complain.md
lukasIO Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wild-tools-complain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@livekit/rtc-node": patch
---

Temporarily disable pino-pretty transport
24 changes: 14 additions & 10 deletions packages/livekit-rtc/src/log.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,21 @@ const isProduction = process.env.NODE_ENV === 'production';

const defaultOptions: LoggerOptions = { name: 'lk-rtc' };

const devOptions: LoggerOptions = {
...defaultOptions,
transport: {
target: 'pino-pretty',
options: {
colorize: true,
},
},
};
/**
* temporarily disabling the transport option as there might be a memory leak in some corner cases related to it
* see https://github.com/pinojs/pino/issues/2370
Copy link
Contributor

@1egoman 1egoman Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Maybe also link #603 here?

Copy link
Contributor Author

@lukasIO lukasIO Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the backlink via this PR/squash commit, opting to leave it at that

*/
// const devOptions: LoggerOptions = {
// ...defaultOptions,
// transport: {
// target: 'pino-pretty',
// options: {
// colorize: true,
// },
// },
// };

const log = pino(isProduction ? defaultOptions : devOptions);
const log = pino(defaultOptions);
log.level = isProduction ? 'info' : 'debug';

export type LogLevel = LevelWithSilent;
Expand Down
Loading