Conversation
1. success/failure/drop counter.
2. queue length histogram.
- doing this only for resource_url_notifier which does a per room
queue as queue length is easily available. This is the one
currently in use.
- worker pool based notifier will need a change in `core` package to
return a queue length when enqueuing.
|
paulwe
approved these changes
Jun 4, 2025
webhook/stats.go
Outdated
| Name: "dispatch_total", | ||
| ConstLabels: constLabels, | ||
| }, []string{"status", "reason"}) | ||
| prometheus.MustRegister(promWebhookDispatchTotal) |
Contributor
There was a problem hiding this comment.
promauto.New* creates and registers metrics with the default registry in the same function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corepackage to return a queue length when enqueuing.