Skip to content

Protocol error handling#1184

Merged
boks1971 merged 6 commits intomainfrom
raja_errors
Sep 2, 2025
Merged

Protocol error handling#1184
boks1971 merged 6 commits intomainfrom
raja_errors

Conversation

@boks1971
Copy link
Contributor

@boks1971 boks1971 commented Sep 2, 2025

For signalling responses,

  • RequestResponse will be used
  • If request has a request_id field (currently only in UpdateParticipantMetadata), a success response is also expected by sender.
  • For errors, the request is included in the response so that senders have context of the request which caused the error.

This PR adds a few requests to the response. We can add more over time.

@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2025

⚠️ No Changeset found

Latest commit: 20ccf01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@boks1971 boks1971 requested review from a team, hiroshihorie and lukasIO September 2, 2025 04:47
@boks1971
Copy link
Contributor Author

boks1971 commented Sep 2, 2025

@lukasIO @hiroshihorie please let me know if you have feedback. Going to merge this on @anunaym14 's review. Will address in subsequent PR if there is more feedback.

@boks1971 boks1971 merged commit e46b3f5 into main Sep 2, 2025
5 checks passed
@boks1971 boks1971 deleted the raja_errors branch September 2, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants