Skip to content

fix(connector): redact phone numbers from logs #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anunaym14 merged 2 commits into from
Jan 6, 2026
Merged

fix(connector): redact phone numbers from logs #1357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
817f138
fix(connector): redact phone numbers from logs
anunaym14 Jan 6, 2026
822fbac
generated protobuf
github-actions[bot] Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions livekit/livekit_connector_twilio.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions livekit/livekit_connector_whatsapp.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions protobufs/livekit_connector_twilio.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ message ConnectTwilioCallRequest {
// Optional agents to dispatch the call to
repeated RoomAgentDispatch agents = 3;
// Optional identity of the participant in LiveKit room
// This is used for logging purposes, so it is advised to not put PII in this field.
string participant_identity= 4;
// Optional name of the participant in LiveKit room
string participant_name = 5 [
Expand Down
8 changes: 5 additions & 3 deletions protobufs/livekit_connector_whatsapp.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ import "livekit_rtc.proto";
import "logger/options.proto";

message DialWhatsAppCallRequest {
// Required - The number of the business that is initiating the call
// Required - The phone number id of the business that is initiating the call
Copy link
Member Author

@anunaym14 anunaym14 Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note to make it more clear that it is an id and not a phone number.

On a side note, I have not redacted it since it's not PII

string whatsapp_phone_number_id = 1;
// Required - The number of the user that is supossed to receive the call
string whatsapp_to_phone_number = 2;
string whatsapp_to_phone_number = 2 [(logger.redact) = true];
Copy link
Contributor

@paulwe paulwe Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sip logs phone numbers everywhere - sip participant identities are phone numbers. it seems like we don't care about redacting this

Copy link
Member Author

@anunaym14 anunaym14 Jan 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are open linear tickets to redact these in SIP as well

// Required - The API key of the business that is initiating the call
string whatsapp_api_key = 3 [(logger.redact) = true];
// Required - WhatsApp Cloud API version, eg: 23.0, 24.0, etc.
Expand All @@ -39,6 +39,7 @@ message DialWhatsAppCallRequest {
// Optional - Agents to dispatch the call to
repeated RoomAgentDispatch agents = 6;
// Optional - Identity of the participant in LiveKit room
// This is used for logging purposes, so it is advised to not put PII in this field.
Copy link
Member Author

@anunaym14 anunaym14 Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this note because it's easy to put PII in this field, I've made that mistake myself

string participant_identity= 7;
// Optional - Name of the participant in LiveKit room
string participant_name = 8 [
Expand Down Expand Up @@ -104,7 +105,7 @@ message ConnectWhatsAppCallResponse {
}

message AcceptWhatsAppCallRequest {
// Required - The number of the business that is conencting the call
// Required - The phone number id of the business that is conencting the call
string whatsapp_phone_number_id = 1;
// Required - The API key of the business that is connecting the call
string whatsapp_api_key = 2 [(logger.redact) = true];
Expand All @@ -122,6 +123,7 @@ message AcceptWhatsAppCallRequest {
// Optional - Agents to dispatch the call to
repeated RoomAgentDispatch agents = 7;
// Optional - Identity of the participant in LiveKit room
// This is used for logging purposes, so it is advised to not put PII in this field.
string participant_identity= 8;
// Optional - Name of the participant in LiveKit room
string participant_name = 9 [
Expand Down