Skip to content

Conversation

@andrewnitu
Copy link

No description provided.

Created using jj-spr 0.1.0
@changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2026

⚠️ No Changeset found

Latest commit: 96b285b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@andrewnitu andrewnitu changed the title Add agent events Add event struct; add events field to AgentDeployment Jan 8, 2026
@andrewnitu
Copy link
Author

ref AP-271

string mem_limit = 11;
string cpu_limit = 12;
string server_region = 13;
repeated AgentEvent events = 14;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected to be consumed by livekit-cli?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we have observability events support coming soon, should we just log the events for now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoonsio who is leading this? Let me speak with them to understand if it can fit our use case. We could be publishing quite a decent QPS in the future, so it would need to handle that.

Copy link
Contributor

@yoonsio yoonsio Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is necessary to show events via livekit-cli given that it can be noisy with crashlooping pods. I think displaying aggregated status should be enough and we can follow up with separate API to show the events.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can ask in #project-agent-observability channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants