Expose room updates, support MoveParticipant (protocol 15)#662
Merged
Expose room updates, support MoveParticipant (protocol 15)#662
Conversation
giving clients other information about the room so they could receive
theomonnom
reviewed
Jun 16, 2025
theomonnom
approved these changes
Jun 16, 2025
typester
approved these changes
Jun 16, 2025
|
|
||
| pub const JOIN_RESPONSE_TIMEOUT: Duration = Duration::from_secs(5); | ||
| pub const PROTOCOL_VERSION: u32 = 15; | ||
| pub const PROTOCOL_VERSION: u32 = 16; |
Contributor
There was a problem hiding this comment.
Is this PROTOCOL_VERSION defined in the cloud side as well? I just wanted to know how we manage this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
giving clients other information about the room so they could receive all updates
also ensure that we pass through full participant updates, since sid is expected to change in certain situations (reconnect, move)
FYI @bcherry