Merged
Conversation
ladvoc
approved these changes
Jul 16, 2025
examples/local_audio/src/main.rs
Outdated
| let devices = host.output_devices()?; | ||
|
|
||
| for device in devices { | ||
| println!("Device: {:?}", device); |
Contributor
There was a problem hiding this comment.
This doesn't compile for me; Device does not implement Debug.
|
|
||
| RoomEvent::ParticipantDisconnected(participant) => { | ||
| let participant_identity = participant.identity().to_string(); | ||
| info!("Participant disconnected: {}", participant_identity); |
Contributor
There was a problem hiding this comment.
ParticipantIdentity implements Display, so this can be made a one liner:
info!("Participant disconnected: {}", participant.identity());This also avoids an unnecessary clone.
| livekit = { path = "../../livekit", features = ["rustls-tls-native-roots"]} | ||
| livekit-api = { path = "../../livekit-api", features = ["rustls-tls-native-roots"]} | ||
| log = "0.4" | ||
| cpal = "0.15" |
Contributor
There was a problem hiding this comment.
We can upgrade to cpal 0.16. I tested the example with it and it works just as well.
| } | ||
|
|
||
| // Get LiveKit connection details from CLI arguments or environment variables | ||
| let url = args.url.or_else(|| env::var("LIVEKIT_URL").ok()) |
Contributor
There was a problem hiding this comment.
Clap has a really nice feature that can do this automatically. Once you enable the "env" feature on the crate, you can have it accept the arg either from the CLI or env:
/// LiveKit server URL (can also be set via LIVEKIT_URL environment variable)
#[arg(long, env = "LIVEKIT_URL")]
url: Option<String>
bcherry
approved these changes
Jul 17, 2025
Contributor
|
@chenosaurus, is this ready to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a
examples/local_audioproject that demostrates streaming to LiveKit from local mic input and playing participant audio to local speakier.