Add Clone derive to Room struct #839
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ladvoc
reviewed
Jan 16, 2026
Contributor
ladvoc
left a comment
ladvoc
left a comment
There was a problem hiding this comment.
Good points! I will take a look at the internals and determine what the implications of cloning here are.
|
@jowillianto Just to understand the context of the change a bit better, can you give a quick summary of your use case that requires cloning a room? |
Author
|
Hi! I am trying to pass room around to send messages from multiple threads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea why, but somehow Clone is not derived for livekit::Room. In general, livekit::Room contains only an Arc, and by default this should safely implement Clone without any issue. If the design is to only let livekit::Room own RoomInner, perhaps using a Box is the better way.