Deferred track subscribe. #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not running at all in the following scenario - existing room with a participant - join from Go SDK participant - somehow get a deferred update (needs more investigation if server is sending the track before participant update or Go SDK has a race, probably Go SDK as this happens even before JoinResponse is processed) - that deferred track subscribe never runs as there are no more remote participant updates - even if there were remote participant updates, it ran only when the SID changed. Fix it by running it more gratuitously (after remote participant is created or getting another track subscribe). There is the issue of track going away before defer can run. Have to work on that.
paulwe
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not running at all in the following scenario
Fix it by running it more gratuitously (after remote participant is created or getting another track subscribe).
There is the issue of track going away before defer can run. Have to work on that.
UPDATE on ☝️ : Added code to clear defers on unpublish in this commit.