Skip to content

fix(remote_participant): disconnect reason #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anunaym14 merged 2 commits into from
Nov 12, 2025
Merged

fix(remote_participant): disconnect reason #805

anunaym14 merged 2 commits into from
Nov 12, 2025

Conversation

@anunaym14
Copy link
Member

@anunaym14 anunaym14 commented Nov 12, 2025

Tested with this example: https://gist.github.com/anunaym14/47f0ede23ec9ddfb0e782250fda8d279

 > go run main.go
2025-11-12T21:53:09.241+0530    INFO    disconnect-reason       disconnect_reason/main.go:23    participant disconnected without reason  {"identity": "go-sdk-1", "reason": "CLIENT_INITIATED"}
2025-11-12T21:53:09.241+0530    INFO    disconnect-reason       disconnect_reason/main.go:26    participant disconnected with reason     {"identity": "go-sdk-1", "reason": "CLIENT_INITIATED"}

@anunaym14 anunaym14 mentioned this pull request Nov 12, 2025
Merged
@anunaym14 anunaym14 requested a review from davidzhao November 12, 2025 16:27
@anunaym14 anunaym14 marked this pull request as ready for review November 12, 2025 16:37
anunaym14
anunaym14 commented Nov 12, 2025
View reviewed changes
room.go
Comment on lines -1006 to +1007
r.OnParticipantDisconnect(rp, livekit.DisconnectReason_ROOM_CLOSED)
r.OnParticipantDisconnect(rp, livekit.DisconnectReason_MIGRATION)
Copy link
Member Author

@anunaym14 anunaym14 Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration seems more optimal here? wdyt?

Copy link
Member

@davidzhao davidzhao Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense.

anunaym14
anunaym14 commented Nov 12, 2025
View reviewed changes
room.go
Copy link
Member Author

@anunaym14 anunaym14 Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if unknown_reason is optimal for onRestarting

davidzhao
davidzhao approved these changes Nov 12, 2025
View reviewed changes
room.go
Comment on lines -1006 to +1007
r.OnParticipantDisconnect(rp, livekit.DisconnectReason_ROOM_CLOSED)
r.OnParticipantDisconnect(rp, livekit.DisconnectReason_MIGRATION)
Copy link
Member

@davidzhao davidzhao Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense.

@anunaym14 anunaym14 merged commit 0c0ba02 into main Nov 12, 2025
7 checks passed
@anunaym14 anunaym14 deleted the am/disconnect-reason branch November 12, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anunaym14 @davidzhao