Conversation
🦋 Changeset detectedLatest commit: 3dc9a23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
anunaym14
commented
Dec 8, 2025
anunaym14
commented
Dec 8, 2025
| proto { | ||
| srcDir("$projectDir/protocol/protobufs/") | ||
| exclude("agent/*") | ||
| exclude("infra/*") |
Member
Author
There was a problem hiding this comment.
Ignoring all dirs from srcDir except logger, since that's the only one we need for options that are used to redact fields from the logger for connector (and some other proto models)
anunaym14
commented
Dec 8, 2025
| opt.participantName?.let { this.participantName = it } | ||
| opt.participantMetadata?.let { this.participantMetadata = it } | ||
| opt.participantAttributes?.let { this.putAllParticipantAttributes(it) } | ||
| opt.destinationCountry?.let { this.destinationCountry = it } |
Member
Author
There was a problem hiding this comment.
A bunch of code redundancy here, not sure how to tackle that
Contributor
biglittlebigben
left a comment
biglittlebigben
left a comment
There was a problem hiding this comment.
LGTM but I'll let other folks comment on the URL to URI change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.