Remove actions/cache usage in workflows/build.yaml#275
Merged
dennwc merged 4 commits intolivekit:mainfrom Feb 19, 2025
ScottBrenner:patch-2
Merged
Remove actions/cache usage in workflows/build.yaml#275dennwc merged 4 commits intolivekit:mainfrom ScottBrenner:patch-2
dennwc merged 4 commits intolivekit:mainfrom
ScottBrenner:patch-2
Conversation
ScottBrenner
commented
Feb 1, 2025
ScottBrenner
changed the title
Contributor
Author
|
Hey @Sean-Der spare a moment to review? |
Contributor
|
Sorry @ScottBrenner I don't have write access to this repo. |
dennwc
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No cache is being saved here currently, below messages are logged in workflow executions e.g. https://github.com/livekit/sip/actions/runs/13057592439/job/36432439669#step:3:14
and https://github.com/livekit/sip/actions/runs/13057592439/job/36432439669#step:7:2
As such, the usage of actions/cache here is not really doing anything - proposing removing.
Modifying the usage of actions/cache a bit following https://github.com/actions/cache/blob/main/examples.md#go---modules does not resolve these messages, the workflow would need to additionally - or instead - utilize https://github.com/actions/setup-go?tab=readme-ov-file#caching-dependency-files-and-build-outputs